Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality to Dispatcher-agent for handling RPC command Reques… #568

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

Add functionality to Dispatcher-agent for handling RPC command Reques… #568

wants to merge 12 commits into from

Conversation

tsirlapu
Copy link
Contributor

@tsirlapu tsirlapu commented Oct 9, 2024

…ts from Cloudadapter-agent

PULL DESCRIPTION

Provide a 1-2 line brief overview of the changes submitted through the Pull Request...

Impact Analysis

Info Please fill out this column
Root Cause Specifically for bugs, empty in case of no variants
Jira ticket Add the name to the Jira ticket eg: "NEXMANAGE-622". Automation will do the linking to Jira

CODE MAINTAINABILITY

  • Added required new tests relevant to the changes
  • Updated Documentation as relevant to the changes
  • PR change contains code related to security
  • PR introduces changes that break compatibility with other modules/services (If YES, please provide description)
  • Run go fmt or format-python.sh as applicable
  • Update Changelog
  • Integration tests are passing
  • If Cloudadapter changes, check Azure connectivity manually

Code must act as a teacher for future developers

@gblewis1
Copy link
Contributor

gblewis1 commented Oct 9, 2024

add rpc binary to apparmor

ref:

apparmor file for non-yocto

inbm/dispatcher-agent/fpm-template/etc/apparmor.d/usr.bin.inbm-dispatcher

apparmor file for yocto

./inbm/packaging/yocto/common/usr.bin.inbm-dispatcher

@tsirlapu
Copy link
Contributor Author

add rpc binary to apparmor

ref:

apparmor file for non-yocto

inbm/dispatcher-agent/fpm-template/etc/apparmor.d/usr.bin.inbm-dispatcher

apparmor file for yocto

./inbm/packaging/yocto/common/usr.bin.inbm-dispatcher

Need to get the path of the rpc.. and will add the commit to finish the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gblewis1 gblewis1 gblewis1 left review comments

@nmgaston nmgaston Awaiting requested review from nmgaston nmgaston will be requested when the pull request is marked ready for review nmgaston is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsirlapu @gblewis1